chore: Docker 설정 간소화 및 CI/CD 안정화#67
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Docker configuration and updates the application's naming conventions to 'prepair-backend-java-api'. Key changes include an expanded .dockerignore, a more frequent Docker health check, and the addition of a PostgreSQL health check in the docker-compose file to ensure proper service orchestration. A review comment suggests improving the database health check by specifying the database name in the pg_isready command for better reliability.
| volumes: | ||
| - postgres-data:/var/lib/postgresql/data | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "pg_isready -U ${POSTGRES_USER}"] |
There was a problem hiding this comment.
PostgreSQL 상태 확인 시, 서버가 연결을 수락하는지 확인하는 것뿐만 아니라, 애플리케이션이 사용할 특정 데이터베이스가 준비되었는지 확인하는 것이 더 안정적입니다. pg_isready에 -d 플래그를 추가하여 데이터베이스 이름을 명시하는 것을 권장합니다.
test: ["CMD-SHELL", "pg_isready -d ${POSTGRES_DB} -U ${POSTGRES_USER}"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈 (Related Issue)
📝 작업 내용 (Description)
Docker 설정 간소화
docker-compose-dev.yml→docker-compose.yaml로 이름 변경 및 간소화docker/하위 프로덕션 설정을deploy/로 이동하여 배포 관련 파일 경로 통일.dockerignore추가로 이미지 빌드 컨텍스트 최적화CI/CD 안정화
ci.yaml에setup-qemu-action추가 — arm64 크로스 빌드를 런너 환경에 의존하지 않고 명시적으로 보장cd.yaml이미지 정리 로직을docker image prune→docker rmi로 교체 (resolves fix: docker image prune의 reference 필터 미지원으로 인한 의도치 않은 전체 이미지 삭제 #66)파일 확장자 통일
application-*.yml→.yaml,docker-compose.yml→.yaml로 통일🔄 변경 유형 (Type of Change)
✅ 체크리스트 (Checklist)
💬 추가 코멘트 (Additional Comments)
docker image prune의--filter "reference="는 dangling 이미지에만 적용되어 태그가 붙은 이전 이미지는 삭제되지 않았습니다.수정 후에는
docker images로 대상 이미지를 명시적으로 조회하여 최신 1개만 남기고 나머지를 삭제합니다.